Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking getByToken migration, part 1 (RecoTracker/CkfPattern and RecoTracker/DebugTools) #556

Merged
merged 12 commits into from
Aug 19, 2013

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 16, 2013

Migration also of CkfPattern, on top of 555
Notes:

  • the data access through the MeasurementTracker is not yet migrated (requires a major redesign of the MT class)
  • some non-production code in DebugTools has not been migrated, will do later

@ghost ghost assigned thspeer Aug 16, 2013
@ktf
Copy link
Contributor

ktf commented Aug 16, 2013

@nclopezo can you test this?
@slava77 @thspeer can you check and sign?

@nclopezo
Copy link
Contributor

Hi,

I took these changes on top of CMSSW_7_0_X_2013-08-16-0200, I ran the unit tests and RelVals, all tests passed.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/138/consoleFull

@thspeer
Copy link
Contributor

thspeer commented Aug 19, 2013

Signed.
No changes seen in tests
Tested with CMSSW_7_0_X_2013-08-16-1400 (556-trkP1)

@cmsbuild
Copy link
Contributor

The following categories have been signed by speer (a.k.a. @thspeer on GitHub): Reconstruction

@cms-git-reconstruction

@ktf
Copy link
Contributor

ktf commented Aug 19, 2013

@demattia can you sign?

@cmsbuild
Copy link
Contributor

The following categories have been signed by @demattia: Calibration and Alignment

@cms-git-alca

ktf added a commit that referenced this pull request Aug 19, 2013
Tracking getByToken migration, part 1 (RecoTracker/CkfPattern and RecoTracker/DebugTools)
@ktf ktf merged commit 71294c7 into cms-sw:CMSSW_7_0_X Aug 19, 2013
nclopezo pushed a commit to nclopezo/cmssw that referenced this pull request Apr 30, 2014
Add new data from github cms-data.
@gpetruc gpetruc deleted the tracking-getByToken-part1 branch September 30, 2015 21:44
bianchini added a commit to bianchini/cmssw that referenced this pull request Nov 24, 2016
cmsbuild pushed a commit that referenced this pull request Oct 7, 2020
Minor bug fixes:
  - fix a typo in EventFilter/EcalRawToDigi/plugins/BuildFile.xml .

Clean up:
  - remove obsolete ArrayShadow class;
  - remove obsolete profiling functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants